commit | 2cfc0a0eb55dc9ecbc16957ea98d2e378c130136 | [log] [tgz] |
---|---|---|
author | Jacobo Aragunde Pérez <jaragunde@igalia.com> | Wed Feb 08 18:33:12 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 08 18:33:12 2023 |
tree | 7e1538e08119c10011de3f1ee3b9fb5573a2d547 | |
parent | 93863c457119e7dd6017a917db536c31b5494b15 [diff] |
DCHECK when default action is triggered on node which has none. There is nothing in our code preventing from running the default action on an accessibility node, even when that node has the kNone default action set. Some ATs even relied on this behavior. We add a DCHECK so we can detect cases when this is happening, address them individually, and finally stop exposing default actions on nodes that haven't them. Bug: 1370076, 1379347, 1382034 Change-Id: I75e08867695f61d1358dc9855a446d971f748516 AX-relnotes: no user-facing changes. Cq-Include-Trybots: luci.chromium.try:linux-blink-web-tests-force-accessibility-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4098912 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/main@{#1102815}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.