commit 2d164acde92439ae81649811eabf6fda28ff2f7e
author Youssef Bourouphael <ybourouphael@google.com> Fri Jan 17 15:10:38 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jan 17 15:10:38 2025
tree 510d3c1a1ff4b35b7c1c9b970f78a296c96932c1
parent 8f6adedf448ac3af675b4d14a6ffa9568bbdb786

Reland "Added a TestBidBuilder class create bids within tests."

This reverts commit 4f4a7664f17a1695ca905d13c1f018a498e0c83e.

Reason for revert: Edit to build file ensuring mojo_bindings are
built without depending on internals.

Original change's description:
> Revert "Added a TestBidBuilder class create bids within tests."
>
> This reverts commit d9c1a30d7b0b5f3e62a60bde571a83bc56d7778f.
>
> Reason for revert: This CL looks a cause of win-arm64-dbg compile failure. https://ci.chromium.org/ui/p/chromium/builders/ci/win-arm64-dbg/5830/overview
>
> Original change's description:
> > Added a TestBidBuilder class create bids within tests.
> >
> > Currently, each test that utilizes a bidder worklet bid constructs it
> > directly using the Bid constructor. This necessitates modifying over 170
> > test cases each time a new member is added to the Bid class.
> >
> > The TestBidBuilder provides a simple way of bid creation and reduces
> > code redundancy. This change ensures tests are less impacted by
> > redundancy. This change also ensures tests are less impacted by future
> > modifications to the Bid class and improves the overall readability
> > of the test suite.
> >
> > Change-Id: Ie722ba96c87bed71cc2bfa1c474f659ce21cefa3
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102327
> > Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> > Reviewed-by: Caleb Raitto <caraitto@chromium.org>
> > Commit-Queue: Youssef Bourouphael <ybourouphael@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1406896}
>
> Change-Id: I676189b40ae7609463a21f815b7b865f221ff95e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6169795
> Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Owners-Override: Shunya Shishido <sisidovski@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1407061}

Change-Id: I71ba20468c6b8a9cddb154d4018f4a787fd21ee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180097
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Commit-Queue: Youssef Bourouphael <ybourouphael@google.com>
Cr-Commit-Position: refs/heads/main@{#1407894}