commit | 2d2b9225a67898e8ea0a12587fac41e2d350c377 | [log] [tgz] |
---|---|---|
author | tzik <tzik@chromium.org> | Tue Jul 31 04:50:36 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jul 31 04:50:36 2018 |
tree | ba725493148cc9812d8de541f3fc0abec03a7e20 | |
parent | 7e36928e77dc79a6aaa532ea9a13ebd87f415e0a [diff] |
Keep shared web::test::HttpServer instance alive The web::test::HttpServer instance returned by GetSharedInstance has zero reference count initially, HttpServer::StartOrDie implicitly increments the reference count through base::Bind, and its embedded_test_server_ destruction decrements the reference count. That is, once the server stopped, the shared instance is destroyed, and GetSharedInstance() starts returning a stale pointer. After this CL, the resulting instance of GetSharedInstance has non-zero reference count, so that it keeps alive after server stop. Bug: 866456 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1f13dff1e86d08efb28b5805ae73426b874a4f80 Reviewed-on: https://chromium-review.googlesource.com/1146881 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#579314}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .