| commit | 2d595e13af5fea9b50bd08afaf37b55f6d1fb115 | [log] [tgz] |
|---|---|---|
| author | Dominic Farolino <dom@chromium.org> | Thu Aug 18 16:53:36 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 18 16:53:36 2022 |
| tree | ddca73fc8d8dfe95c2b59f5b9a24c150e7b2f7de | |
| parent | ae3151616881f2f516fabf25c2a017e29c140066 [diff] |
More thoroughly document how mojom.NavigationClient gets reused
RenderFrameImpl maintains a mojom.NavigationClient implementation that
acts as a:
1.) "Request" navigation client:
For navigations on a target frame where the initiator is local.
This is used to cancel navigations that have been sent to the
browser, and to listen for when the browser "drops" navigations
2.) "Commit" navigation client:
Which the browser uses to commit navigations to.
Sometimes the same navigation client implementation is used as both, and this CL more thoroughly documents when and how this happens.
Change-Id: Ib3192d1b0f911839cd8a9d9119670cebbc4e1281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835467
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1036655}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.