Google Git
Sign in
chromium / chromium / src / 2d9e45c742d1eb51dda0dd5c41f8306f10aa80cc
commit2d9e45c742d1eb51dda0dd5c41f8306f10aa80cc[log] [tgz]
authorDaniel Vogelheim <vogelheim@chromium.org>Wed Jan 19 18:51:52 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 19 18:51:52 2022
treec8663b4fb30ce17602f5e0234909039f87112b51
parentb2b99626f51b02aebf29c7430373d76595d63b70 [diff]
[Trusted Types] Ensure execCommand('insertHTML') is TT-safe.

Trusted Types protects against XSS by providing a configurable
boundary for HTML insertion into the DOM. execCommand with the
"insertHTML" command works around these. This introduces Trusted
Types check for execCommand("insertHTML") that are the exact
equivalent of element.innerHTML.

Tests ensure that - if TT is not enabled - execCommand will work
as before. Tests also ensure that - if TT is enabled - execCommand
with "insertHTML" will obey TT policies and the default policy,
while other sub-commands will continue to work as before.

This is a re-land of crrev.com/c/3048161. What has changed from that
earlier attempt is that the website that caused the revert of that
CL has changed its usage. Use counters generally indicate very low
remaining (mis-)use of the feature we're guarding against.

Bug: 1230567
Change-Id: I00516875f10f992442f3f9986ba81e630ff13f70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3398119
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#961049}
7 files changed
tree: c8663b4fb30ce17602f5e0234909039f87112b51
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.