commit | 2da0bb0b55aaa05dacf6870680a3d5d9aadd32b3 | [log] [tgz] |
---|---|---|
author | Sangbaek Park <sangbaekpark@chromium.org> | Tue Jun 14 20:21:39 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jun 14 20:21:39 2022 |
tree | ea2b249125785af6489fa5f24be0ab44a8fae531 | |
parent | da5755659124336b0a575307844405fd23e23a28 [diff] |
media: Use `base::flat_map<>::contains()` Use `base::flat_map<>::contains()` instead of `find()` and `count()` for the better code readability: * It is less readable and could easily lead another bugs if we mix up using `find()`, `count()` and `end()` methods of STL map or chromium flat_map. * Replaced with `contains()` method for `base::flat_map<>` (chromium/src/base/containers/flat_map.h) only since C++20 is not supported yet for Chromium (go/cpp-chrome). * Target path: /src/media * Exception: Did not replace them if the iterator returned by `find ()` method is used in the code. ``` autoninja -C out/Default media_unittests out/Default/media_unittests ``` Bug: 1332591 Change-Id: Idf5374daf26c777672a6c4a672e5b51e5155ed79 Test: All tests passed on an instance of Linux cloudtop Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3696614 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sangbaek Park <sangbaekpark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1014130}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.