commit 2db1d3ab427d32c7978ac06b34187ccb1dc7a337
author Marijn Kruisselbrink <mek@chromium.org> Fri Jul 19 15:53:27 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 19 15:53:27 2024
tree c0013d67efc359981f1df63bcc397426d97b04a7
parent 0046d8811308dbcb21a0b10c4d3ef3e382314f2d

[PWA] Refactor ManifestManager interface and implementation

This changes the mojo interface for ManifestManager.RequestManifest
to include an explicit request result, indicating if the manifest
was fetched successfully, and if not, for what reason it failed.
This way calling code will be more easily be able to distinguish between
various failure scenarios without having to decode the various
combinations of manifest and manifest url being null and/or empty. This
will then pave the way in a follow-up to return the default manifest
in cases where currently we return an empty manifest to signal failure.

Also refactors the internals of the ManifestManager implementation to
hopefully make its internal state easier to understand (it now only
stores "completed" results in its members to cache for future requests,
rather than the previous implementation where at times partial results
were also stored in the same members when in the middle of a request).

This CL is intended to not have any behavioral changes.

Bug: 344987157
Change-Id: I346e5d5b64b320eab10b4311c577de58242c3edc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5664310
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1330274}