Google Git
Sign in
chromium / chromium / src / 2df1b2af9d596a7a2ab5257db645acea4374ad27
commit2df1b2af9d596a7a2ab5257db645acea4374ad27[log] [tgz]
authorArthur Sonzogni <arthursonzogni@chromium.org>Fri May 26 09:54:22 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 26 09:54:22 2023
tree9532ed85ded7594322aefbbca5fc2ba414372da1
parente4a608fe637d207c47976ef4face06cc7245b17b [diff]
Remove raw_ptr in arguments and return value.

raw_ptr was meant to be used in member variables only. Some developers
are using them in return values and arguments. This isn't really a
problem, but not very useful.

In most cases, developers are copy-pasting nearby code, causing this
pattern to propagate further away. So it is better to stop this early.

**Hidden motivation**: I am playing with automatically finding every
pre-existing dangling pointers: https://godbolt.org/z/o8adYnc7a
`raw_ptr` in arguments causes declaration and implementation signature
to differ in those locations. If we could get rid of them here, my life
would be slightly easier.

Bug: 1400059
Change-Id: I7096057c1f7108dabb086820ee460302cc7f7b16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567506
Owners-Override: Bartek Nowierski <bartekn@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1149633}
25 files changed
tree: 9532ed85ded7594322aefbbca5fc2ba414372da1
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.