Reduce work updating pending surfaces When BeginFrameSource ticks it sends out OnBeginFrame() messages to all BeginFrameObservers. Each CompositorFrameSink that gets OnBeginFrame() will send out a SurfaceDamageExpected message to all SurfaceObservers. Each window has a DisplayDamageTracker that is a SurfaceObserver. Even though only the window that is embedding a particular frame sink cares about the expected damage, all of DisplayDamageTrackers receive OnSurfaceDamageExpected() message. This may trigger recomputing pending surfaces via DisplayDamageTracker::HasPendingSurfaces(). When there are many windows open at the same time this is a significant amount of wasted work every vsync. Since DisplayDamageTracker is linked to specific BeginFrameSource we can filter out surface damage earlier based on the begin frame source_id. This will ensure pending surfaces are only recomputed when a change is possible. A trace was recorded on Linux release build without DCHECKs at both ToT [1] and ToT with this CL applied [2]. In the traces there were 10 windows open, 9 had poster circle animating and the tenth had the trace viewer to record the trace. The average CPU time in DisplayDamageTracker::SurfaceDamageExpected was 4.77us at ToT and 1.99us with this CL applied. [1] https://ui.perfetto.dev/#!/?s=b163f091c6faedabdfc011587c000febfea519956e2ad02b228cdacd765cc265 [2] https://ui.perfetto.dev/#!/?s=323b3c1378ff0de5a50164d961aa0975e3eb0221e63e2f2718969bf74d4db163 Bug: 1459438 Change-Id: I9804f83a9cb2ac7f517f0ea2370108b519c8afa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4662931 Commit-Queue: Kyle Charbonneau <kylechar@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/main@{#1170568}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.