Google Git
Sign in
chromium / chromium / src / 2e4c0f4bd946095dcd218248b1b695d39de926cf
commit2e4c0f4bd946095dcd218248b1b695d39de926cf[log] [tgz]
authorMikel Astiz <mastiz@chromium.org>Thu Jul 22 15:39:11 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 22 15:39:11 2021
tree97d5caf9e3259c4f8a1a58699e2f61b321ffea70
parent7962e44ae5b9cbcca3df8182a8916e4f636d0338 [diff]
[sync] Fix crash due to rare corrupt bookmark data

This guards that GUID-inferring logic against incoming data that is
considered corrupt: the case where an incoming bookmark has a client tag
hash (which means it was created with a GUID) and yet the update
includes no GUID in specifics. This means the GUID was cleared out by
some old client, which is problematic and something that the server
should likely refuse to do.

For these cases, the GUID cannot be actually inferred and hence the
update should be ignored.

On top of that, to be cautious about users that already ran into this
state, the patch introduces a quirk to best-effort infer the GUID by
other means, if the bookmark was already tracked locally. This logic
is introduced merely to avoid a regression, because although some users
do run into crashes, the previous implementation may sometimes just fix
the data corruption by issuing a commit (due to implementation
artifacts).

Change-Id: I80b072aa41f17111ab2b4c5c95d09a9d0285059f
Bug: 1231450
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3045398
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#904341}
8 files changed
tree: 97d5caf9e3259c4f8a1a58699e2f61b321ffea70
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.