Google Git
Sign in
chromium / chromium / src / 4a60182c5fa5a31b06c3fbabef4d3a50923222d3
commit4a60182c5fa5a31b06c3fbabef4d3a50923222d3[log] [tgz]
authorAndrew Rayskiy <greengrape@google.com>Wed Mar 12 21:57:50 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Mar 12 21:57:50 2025
treeb8c109974ef72dd58debaf5dfe71c3a8fdb188a4
parent2c130963d4ab2f4ba75126dbd154a047937af817 [diff]
iwa: Decoupling SignedWebBundleReader from IwaReaderFactory

This CL attempts to decouple the two classes that are currently
heavily intertwined:
* SwbnReader is created by IwaReaderFactory and tasked with reading the
  integrity block;
* After reading the control returns to IwaReaderFactory which then
  validates the integrity block;
* Depending on the outcome, IwaReaderFactory calls into SwbnReader again
  and instructs it to proceed with signature verification.

This CL inverts the controls -- instead of four hops (IwaReader ->
SwbnReader -> IwaReader -> SwbnReader -> IwaReader) we now have only
one; the SwbnReader will verify signatures autonomously if the
corresponding flag is set at creation time; and the additional trust
checks on the integrity block will be performed after signature
verification.

Bug: 402244836
Change-Id: If92549b77489f75007e0bca808f179073e7dbf6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6333079
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Commit-Queue: Andrew Rayskiy <greengrape@google.com>
Cr-Commit-Position: refs/heads/main@{#1431772}
8 files changed
tree: b8c109974ef72dd58debaf5dfe71c3a8fdb188a4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.