Remove IsCrosapiInterfaceAvailable() functions and use IsSupported() This CL adds a new function IsSupported<CrosapiInterface>() and replaces all of the following functions with it: - chromeos::LacrosService::IsAccountManagerAvailable() - chromeos::LacrosService::IsBrowserCdmFactoryAvailable() - chromeos::LacrosService::IsMediaSessionAudioFocusAvailable() - chromeos::LacrosService::IsMediaSessionAudioFocusDebugAvailable() - chromeos::LacrosService::IsMediaSessionAudioFocusDebugAvailable() - chromeos::LacrosService::IsMetricsReportingAvailable() - chromeos::LacrosService::IsMultiCaptureServiceAvailable() - chromeos::LacrosService::IsSmartReaderClientAvailable() - chromeos::LacrosService::IsSensorHalClientAvailable() - chromeos::LacrosService::IsVideoCaptureDeviceFactoryAvailable() - chromeos::LacrosService::IsStableVideoDecoderFactoryAvailable() This CL changes the way to check whether some particular interface is supported by ash-chrome. IsSupported<Interface>() checks whether GetInterfaceVersion<Interface>() returns a non-negative number at runtime. Previously, above functions were comparing the result of CrosapiVersion() with the minimum crosapi version for each interface. However, that way is possibly unreliable because some interfaces might be removed in the future versions. Thus, it would be better to check at runtime using GetInterfaceVersion(). Bug: 1433159 Change-Id: I058b037d22468caadfbfb2746bc387f8d1e315e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4422116 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Jun Ishiguro <junis@google.com> Reviewed-by: Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1141701}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.