commit 2eafb246fe8c232177c477029a7ea29d42c30c8c
author Dana Fried <dfried@chromium.org> Tue Jul 25 16:33:20 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jul 25 16:33:20 2023
tree 24aa294d953a73c8e4802fb270227acfbbb526de
parent 1c6ad6116b20315ba3bf40064f9cef8d6f5bd458

[User Education] Allow multiple annotations on a menu

Help bubbles attached to menus are considered "annotations" and handled
by a special event-forwarding system to allow closing the help bubble
via mouse when the menu is showing (otherwise, the menu would lose focus
and disappear).

This was implemented assuming only a single help bubble attached to any
given menu, but with tutorials that can attach to submenus, there can
briefly be two simultaneous help bubbles, breaking this assumption.

Now menus may have any number of annotations; events will be sent to
each in turn, and the first one that reports that it handles the event
will take precedence.

This CL mostly changes from using a WeakAutoReset to a
CallbackListSubscription, which is a more natural return value for
adding an annotation callback anyway. A test is added to make sure that
the double-bubble actually works.

Change-Id: I5e49ae283832957f9e969a8266de07bea8096563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4713887
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Mickey Burks <mickeyburks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1174895}