commit | 2ef5368f9ac863e3ba0dea59323ead8f24ee8ba4 | [log] [tgz] |
---|---|---|
author | Rakina Zata Amni <rakina@chromium.org> | Thu Aug 01 05:05:09 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 01 05:05:09 2024 |
tree | f5fcf44bfe5973c362892b92e8efa00de39cebde | |
parent | ee5b4dc6b87457c0f270ec0012b5029256174507 [diff] |
Revert "[toolbarpinning] Update Chrome Labs code for ToolbarPinning." This reverts commit 503e462d723aee3925daee7c787a773a14149462. Reason for revert: Potentially causing test failures, e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/Network%20Service%20Linux/84144/overview Original change's description: > [toolbarpinning] Update Chrome Labs code for ToolbarPinning. > > With ToolbarPinning, the Chrome Labs button should now use its Pinned Toolbar Action Button, rather than the current toolbar button. This CL adds code to choose the appropriate button for anchoring the Chrome Labs bubble. It also moves the ChromeLabsCoordinator into BrowserWindowFeatures and updates ownership of Chrome Labs components. > > This CL also introduces a migration to pin the Chrome Labs button by default. > > Bug: 323962536 > Change-Id: Icddc545659fb35038cc4eba2d61a7ffcdc47c620 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5710713 > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Commit-Queue: Joseph Park <josephjoopark@chromium.org> > Reviewed-by: David Pennington <dpenning@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1335797} Bug: 323962536 Change-Id: I9a8a5cbd88c5b6d355da98b79eeb967b833d602f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5755525 Owners-Override: Rakina Zata Amni <rakina@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#1335867}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.