commit 2f2615d47ac182c0eeb0597356cc0a559ae83c8d
author Tomasz Wiszkowski <ender@google.com> Thu Sep 26 21:56:02 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Sep 26 21:56:02 2024
tree 132533375fc84a7cdb4f207b8048a5d251405587
parent f7528e711be1e2831198547aa45ebc3402d81bff

Drop C-style arrays from generated structs

TLDR:
Change replaces the following fields in structs generated from
JSON:
  - const TYPE* array_name
  - size_t array_name_size
with
  - const base::span<const TYPE> array_name
and removes some unsafe buffer usage warning suppression pragmas.

This change proposes replacing pointer-and-length struct fields with
their base::span<> equivalent. The change does not entirely abandon
the C-style structs, but hides and abstracts them so that iterating
elements no longer causes unsafe buffer usage errors.

The change addresses C-style arrays in structs only, and does not
solve the equivalent case of generated collections encompassing all
JSON elements (such as `kAllEngines`). For that reason many pragma
statements could not be removed yet.

Bug: b/40285824, b/352691908
Change-Id: I32820f62eedb241926f5b47af778d61158ac627c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5888845
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1360785}