commit 2f38db1ce5f316cff6885d24d06b3d0a5ae225fc
author Martin Kreichgauer <martinkr@google.com> Mon Oct 19 19:45:07 2020
committer Commit Bot <commit-bot@chromium.org> Mon Oct 19 19:45:07 2020
tree c2bc00b83fbc5c3c2f7bb34620edba9d002b1954
parent 95e2412f83b8057d00d92c32636af945b951587f

fido: use AuthTokenRequester in MakeCredentialRequestHandler

This removes logic for obtaining a pinUvAuthToken in
MakeCredentialRequestHandler in favor of using AuthTokenRequester.

There should be no behavior changes as to whether PIN or internal UV is
requested for a given makeCredential request. (And existing
PIN/UV-related test cases in authenticator_impl_unittest.cc provide
decent coverage to ensure that this is indeed the case.)

There is a small change in handling authenticator removal mid-request:
This would previously only abort the request if the handler was waiting
for a PIN. It now generally aborts the request as long as an
authenticator has been chosen, but the request hasn't finished (e.g.
because a it is waiting to enroll a biometric template).

Also changes VirtualCtap2Device to return CTAP2_ERR_UV_BLOCKED if a
failed UV attempt locks the authenticator, as the spec prescribes.

Bug: 1139111
Change-Id: I4c07b16294ffba4a15ea813e182ad669645bf703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469445
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818580}