Google Git
Sign in
chromium / chromium / src / 2f3cf950f509ef2f03e28f44fb604c593c2090f3
commit2f3cf950f509ef2f03e28f44fb604c593c2090f3[log] [tgz]
authorDaniel Rubery <drubery@chromium.org>Wed Jul 06 22:28:31 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 06 22:28:31 2022
tree2f6dd03b449c8d57b3978aefe0d817746db784e2
parent5cc7c15f9f1533f951fff38a676e040342918432 [diff]
Revert "Use GetPaintRecord instead of doing a new PaintPreview in Phishing Detection"

This reverts commit 2b60b22f1048edcae86c00db0a3d8f9f2d8f9cb6.

Reason for revert: Triggering some DCHECKS, https://bugs.chromium.org/p/chromium/issues/detail?id=1342268

Original change's description:
> Use GetPaintRecord instead of doing a new PaintPreview in Phishing Detection
>
> Client Side Phishing Detection currently does a new PaintPreview on
> page load to get the input for the model. This does a lot of layout
> work that is duplicated with rendering/painting. This CL uses the
> existing cache of painting results held in the LocalFrameView instead
> of redoing the work of computing it.
>
> Bug: 1338944
> Change-Id: Ie2a9ea7cac212e2be54940ef8a551830c3319d81
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3727009
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Daniel Rubery <drubery@chromium.org>
> Reviewed-by: Rohit Bhatia <bhatiarohit@google.com>
> Cr-Commit-Position: refs/heads/main@{#1019799}

Bug: 1338944, 1342268
Change-Id: Ic00b5f80072dc8eb3d3b3ad41354dfec4754bb86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3748141
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1021402}
4 files changed
tree: 2f6dd03b449c8d57b3978aefe0d817746db784e2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.