Google Git
Sign in
chromium / chromium / src / 2faf9efc23b84d150883b87d98c55211db1e677f
commit2faf9efc23b84d150883b87d98c55211db1e677f[log] [tgz]
authorGaston Rodriguez Lopez <gastonr@microsoft.com>Sat Aug 05 02:12:29 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Aug 05 02:12:29 2023
tree4d3ac9635b7d9cc8604cd7a1093409dbd4b604d9
parentdbb0a6f97b7e902fea2bdfa551801f9d6ee9b384 [diff]
Address comments on code guidelines.


Make setForcedColorsAndDarkPreferredColorScheme emulate forced colors.

The function Internals::setForcedColorsAndDarkPreferredColorScheme is
used in the web tests based on dynamic-color-scheme-change.html

This function sets forced colors from the renderer process on the web
theme engine and the current native theme, but doesn't create any
color providers to be used by the web theme engine.
This CL extracts the creation of the emulated forced colors color
provider in WebThemeEngineDefault into it's own function, and calls
the new function to create the color providers to be used when
rendering fluent scrollbars.

Bug: 1467299
Change-Id: Ib72560afaa430aede818ab5331ba6fc9541425b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4736034
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Rahul Arakeri <arakeri@microsoft.com>
Commit-Queue: Gaston Rodriguez <gastonr@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1179974}
8 files changed
tree: 4d3ac9635b7d9cc8604cd7a1093409dbd4b604d9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.