XML: Merge CDATA nodes on chunk boundaries

When a single CDATA node spans the boundary of an input XML chunk fed to
libxml, libxml emits two separate SAX events for the same node: one for
the tail end of the previous chunk, and one for the head of the next
chunk.

XmlDocumentParser appends a new CDATA node to the document for each
such event, so if a chunk boundary happens to fall in the middle of a
CDATA node's contents, we will incorrectly parse this as two distinct
CDATA nodes.

This changes XmlDocumentParser to merge such CDATA nodes together
whenever the second CDATA event represents the first content processed
from a new chunk of input data.

While we will now incorrectly merge two distinct CDATA if a chunk
boundary happens to fall precisely between them, this should be a much
less likely occurrence than a chunk boundary falling anywhere within a
large CDATA node.

A more robust fix will require changes to the libxml API.

Fixed: 1362073
Change-Id: I4f5ae717951e92dab1dafb0c497afc2e775d4590
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907930
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1049321}
2 files changed
tree: 7484220b7d2b3f2bea6728cc0c7d411fd3744a74
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.