XML: Merge CDATA nodes on chunk boundaries When a single CDATA node spans the boundary of an input XML chunk fed to libxml, libxml emits two separate SAX events for the same node: one for the tail end of the previous chunk, and one for the head of the next chunk. XmlDocumentParser appends a new CDATA node to the document for each such event, so if a chunk boundary happens to fall in the middle of a CDATA node's contents, we will incorrectly parse this as two distinct CDATA nodes. This changes XmlDocumentParser to merge such CDATA nodes together whenever the second CDATA event represents the first content processed from a new chunk of input data. While we will now incorrectly merge two distinct CDATA if a chunk boundary happens to fall precisely between them, this should be a much less likely occurrence than a chunk boundary falling anywhere within a large CDATA node. A more robust fix will require changes to the libxml API. Fixed: 1362073 Change-Id: I4f5ae717951e92dab1dafb0c497afc2e775d4590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907930 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1049321}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.