commit | 2fe7ccc0120b5c5810423bdbf40c052c4826d787 | [log] [tgz] |
---|---|---|
author | Taylor Bergquist <tbergquist@chromium.org> | Fri May 05 20:42:40 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 05 20:42:40 2023 |
tree | 21ee182cc351343281d87b2665dc5d85e54b8554 | |
parent | 3160decb13c2dee62d0ccd7e9c414db153dad912 [diff] |
Reland "[SavedTabGroups] Listen to changes from sync for tabs." This is a reland of commit e1e631d81673e79873891cc5496254fa5d82d80e Default-initialized SavedTabGroupWebContentsListener::handle_from_sync_update_ to nullptr. Original change's description: > [SavedTabGroups] Listen to changes from sync for tabs. > > LocalTabGroupListener::UpdateFromSync updates the local group to match the saved group when updates are received from sync, handling adds, removes, navigations, and reorders. Unit tests are added for adding, removing, and navigating, as well as removing the group, but not for reordering, as the sync-side implementation of that is not complete. > > Reordering tabs in a group is implemented in UpdateFromSync, but as those changes aren't yet being synced, so it doesn't work end-to-end. > > Also, this CL includes a couple of fixes to the sync bridge and model to propagate sync changes correctly when the group is removed via sync. > > Change-Id: I0883b0122bfe130c73734613631c5b38ee12b805 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4482519 > Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> > Reviewed-by: Darryl James <dljames@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1139908} Change-Id: I8e8e906f5c964a8af645f5cf3fbc9e4cf1b13928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4509680 Reviewed-by: Darryl James <dljames@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/main@{#1140324}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.