Google Git
Sign in
chromium / chromium / src / 2ff1503106825b0ad9cd806431dbc1530e7c1703
commit2ff1503106825b0ad9cd806431dbc1530e7c1703[log] [tgz]
authorSambamurthy Bandaru <sambamurthy.bandaru@microsoft.com>Wed May 29 10:11:22 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 29 10:11:22 2024
tree1ae3bd3e386d6a50af32ca51df5041646eaa89eb
parentedcd9ea5fcd4af466e8382e2b05306d5158c02fd [diff]
Do not preserve css text transforms for plain text copy

Following spec https://www.w3.org/TR/css-text-3/#text-transform,
the copy/paste payload from |SelectedTextForClipboard()| and
|SelectedHTMLForClipboard()| should not preserve css text transforms
for plain text.

If text node has text-transform set, |TextIteratorTextNodeHandler|'s
|ComputeTextAndOffsetsForEmission()| would get text from
LayoutText::OriginalText() which is devoid of text transforms.

This behavior is controlled with properties added in
TextIteratorBehavior and CreateMarkupOptions defaulting to ignore
text transforms for plain text copy.

Since this is a web facing change, the change is put behind a
runtime feature flag enabled by default. In case there
is an unexpected regression, the feature flag can simply
be turned off (remotely).

Bug: 40343523
Change-Id: I14bce749c1b0eb927bf71c949d8d496c6fbf79f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5399744
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Sanket Joshi <sajos@microsoft.com>
Commit-Queue: Sambamurthy Bandaru <sambamurthy.bandaru@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1307313}
12 files changed
tree: 1ae3bd3e386d6a50af32ca51df5041646eaa89eb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.