commit | 2ff6cd73d11805456cd89f94f436776f20e94e24 | [log] [tgz] |
---|---|---|
author | Xiaochen Zhou <xiaochenzh@chromium.org> | Thu Mar 16 20:46:48 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 16 20:46:48 2023 |
tree | cd8dfc27bc97fdf2324e8b79e744c9dd19bbbb12 | |
parent | fd3287d6e087593a902816a2c7215028ffa5dcaf [diff] |
FLEDGE: Add mapping from ad to size groups to joinAdInterestGroup(). In https://crrev.com/c/4167800, these mappings are added: 1. size groups --> ad size names 2. ad size names --> blink::AdSize This CL adds the mapping: ad --> size group Note: 1. FindMatchingAd is updated. Two ads are considered matching if: a. They have the same url, and neither has any size specified. b. They have the same url, and both have the same size specified. 2. Updated IDL, serialize/deserialize implementations, copy from IDL functions and InterestGroupAd mojom/mojom traits. 3. Added the builder pattern setters for ad size and size groups. 4. Added unit tests and browser tests. 5. The next CL will implement the macro substitution of sizes into the mapped url in fenced frame mapping, when auction is completed. See Turtledove issue: https://github.com/WICG/turtledove/issues/312 See Turtledove PR: https://github.com/WICG/turtledove/pull/417 Bug: http://b/239866637 Related CL on adding sizes to joinAdInterestGroup(): https://crrev.com/c/4167800 Decouple nested blink::InterestGroup::Size: https://crrev.com/c/4296777 Change-Id: I224c7285234e72ff5a7633b15c5ba256e43ef143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4321037 Reviewed-by: Russ Hamilton <behamilton@google.com> Reviewed-by: Liam Brady <lbrady@google.com> Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118329}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.