Google Git
Sign in
chromium / chromium / src / 302f76f4620c9535ff82b688f87e3d6b9d839c3f
commit302f76f4620c9535ff82b688f87e3d6b9d839c3f[log] [tgz]
authorLongbo Wei <longbowei@google.com>Thu Jun 01 01:39:41 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jun 01 01:39:41 2023
treede2650a7e13da2aed939e45271b9cdb1e9466d92
parente53be18d1273aa8023485f229dbea735d6392003 [diff]
shortcuts: Better input hints while inputting keys

* Remove some validation in handleKey(frontend) to allow certain
  invalid accelerators (e.g., shift+j) to pass through and be handled
  by the backend.

* Improve the input hint messages for different cases:
   case 1: Single key -> not a valid accelerator and won't be
           processed. But we also have a backup check in backend:
           kMissingModifier
   case 2: Shift + key -> kShiftOnlyNotAllowed
   case 3. Modifiers + top_row_key -> kKeyNotAllowed
   case 4. Conflict with locked keys -> kConflict
   case 5: Conflict with editable accelerator -> kConflictCanOverride
   case 6. More than 5 accelerators added ->
           kMaximumAcceleratorsReached
   case 7. Other cases -> kSuccess

* Video: http://go/scrcast/NDkwMTE0NjE1OTIxODY4OHwzY2M2YzNkYS1kMw

Bug: b/216049298
Test: browser_tests --gtest_filter=ShortcutCustomizationApp*
Change-Id: Ib593772b148b5ffdc58714f5499aaaf6e5305c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567070
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Commit-Queue: Longbo Wei <longbowei@google.com>
Cr-Commit-Position: refs/heads/main@{#1151612}
3 files changed
tree: de2650a7e13da2aed939e45271b9cdb1e9466d92
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.