Google Git
Sign in
chromium / chromium / src / 3042b1fa73082ae777ad8fbd57b580433058afef
commit3042b1fa73082ae777ad8fbd57b580433058afef[log] [tgz]
authorScott Yoder <scottyoder@google.com>Thu Sep 12 21:34:34 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Sep 12 21:34:34 2024
treee07ea1a4711358125fc7ae3504748b375bf4d620
parentc86282460d8493f3116cb29f133b758c9b5012cb [diff]
[ios] Add an Enhanced Safe Browsing fullscreen promo

This CL refactors the Lens Promo recently built for Tips Notifications,
so that a very similar Enhanced Safe Browsing promo can share the same
code for the promo view and for the bottom sheet instruction view.

A superclass, TipsPromoViewController, is created that displays a promo
with a Lottie animation at the top with a title and subtitle below. Both
LensPromoVC and EnhancedSafeBrowsingPromoVC inherit from this.

Another superclass, InstructionsBottomSheetViewController, displays a
bottom sheet with an InstructionView. Both LensPromoInstructionsVC and
EnhancedSafeBrowsingPromoInstructionsVC inherit from this.

Here is a screencast of the new ESB promo:
http://screencast/cast/NTg2Njk1MDY3MTQ2NjQ5NnwxMTM4YTYzYy01Yg

And here is a screencast of the Lens promo, which is visually unchanged:
http://screencast/cast/NTEwMTMyMjI4NTA4ODc2OHxkMWIwZmVjOC04Nw

Fixed: 361817968
Change-Id: Ibdbb7910467789b71e2c1b3f7dd660d93460748e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836907
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Scott Yoder <scottyoder@google.com>
Cr-Commit-Position: refs/heads/main@{#1354826}
38 files changed
tree: e07ea1a4711358125fc7ae3504748b375bf4d620
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitallowed
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. CPPLINT.cfg
  76. CRYPTO_OWNERS
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.