Remove CriticalPersistedTabData code

Now the Tab fields have been moved back to Tab from
CriticalPersistedTabData reversing the UserData pattern and other
integration points have been removed, the remaining
CriticalPersistedTabData code can be removed. Some notes:
- testShoppingPersistedTabDataSupportedForMaintenance and
testTabDestroyedSupplier started failing with my preliminary
changes ... the issue seemed to be mocking Tab. I re-wrote
the tests to use MockTab instead and they started passing.
Also updated to test the Tab being destroyed rather than not
initialized (Tab#destroyed is not the same thing as !Tab#initialized).
- I noticed acquireSemaphore was missing in testTabDestroyedSupplier
so it lacked synchronization. I added in acquireSemaphore
- setIsTabSaveEnabled is no longer needed and was used in
more tests than necessary.
- Some tests enabled ChromeFeatureList.CRITICAL_PERSISTED_TAB_DATA
for no apparent reason. I removed the annotation.

Bug: b/301661892
Change-Id: Iad1aa342be419c8bec7f80517a173130f4c190e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4884602
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1201194}