commit | 305247a5ea924c59a626b9583c5593d44d400729 | [log] [tgz] |
---|---|---|
author | Timothy Loh <timloh@chromium.org> | Wed May 30 01:02:36 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed May 30 01:02:36 2018 |
tree | 694edd77d4ffe541166871313f076203c60bb5dc | |
parent | a956bd395ecec4bbb4626b1f67e83afb9ce44e35 [diff] |
Make the CrostiniRegistryService::Registration a view on prefs Instead of pulling out all the fields from prefs when we want to get a Crostini app registration into separate data types, we just store a base::Value from prefs and extract values as needed (for safety we clone the value in prefs instead of keeping a pointer, as it may be changed upon updates). This makes it a bit tidier and easier to add new fields. We also remove the LocaleString (= map<string, string>) type which was used to represent strings different values for different locales and only allow users to get the value for the current locale. Change-Id: Ib91f41d65c009e1ef706b61f4e1546f863f3a077 Reviewed-on: https://chromium-review.googlesource.com/1071269 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#562680}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .