[tracing] Avoid perfetto track aliasing in components/input perfetto::Track::FromPointer is problematic because pointer reuse can cause track aliasing in perfetto UI, leading to confusing traces (this was true of legacy TRACE_EVENT_ASYNC as well). To avoid these, we have the following alternatives: 1- Using GetNextGlobalTraceId() instead of a pointer id to guarantee uniqueness. The track will get its name from the first event emitted. 2- Using NamedTrack to scope the pointer to a specific class (an aliased track would always correctly have the same name). This is more appropriate when there are several events emitted to the same track without a clear name. This has the benefit of giving the track a consistent, explicit name. 3- Replace custom track with "sync" instant events with flows. This reduces visual clutter and retain information about where events originated from. This CL applies a migration to of one #1 or #2. Questions for the reviewer: - Design Fit: Is the choice of a dedicated async track (#1/#2) appropriate, or would is be suitable to emit "sync" events with flows (#3). As a rule of thumb, async tracks are appropriate to display a clear async operation (that could be recorded as UMA), or high level / user visible state. - Naming: (when applicable) Is the track name I chose appropriate This CL was uploaded by git cl split. Bug: 432427382 Change-Id: I09426c4a54099a58e0e0afd6e5c341322a5f8ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7874613 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/main@{#1641155}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.