Google Git
Sign in
chromium / chromium / src / 30901df8f50304752f40e9563ad148a27d9729bf
commit30901df8f50304752f40e9563ad148a27d9729bf[log] [tgz]
authorAndrew Xu <andrewxu@chromium.org>Mon Oct 11 16:37:39 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Oct 11 16:37:39 2021
tree9fdbcba42116721f418e12dd1702d7bba165addd
parent54ba1aa03f133490c7dfa72af8906902e9395d86 [diff]
[AppList Sync] Refactor on sync position ownership

Currently both ChromeAppListModelUpdater and ash classes are able to
modify sync positions (i.e. StringOrdinal positions that are synced
among devices) so the ownership is unclear. The similar issues also
happen on other app list item attributes.

This CL creates a delegate class called `AppListModelDelegate` used for
app list item update initiated from ash (such as changing an item's
position during mouse drag). `AppListModelDelegate` relays the item
update requests to the browser side.

In this CL, `AppListModelDelegate` only contains the function related to
item position. In the subsequent CLs, we should let
`AppListModelDelegate` update other item attributes as well.

Read the doc attached to the issue for further details.

Bug: 1251205
Change-Id: Ib7bc4597f050426e777b9b01c9ef7f28d69e17c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3171260
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#930175}
29 files changed
tree: 9fdbcba42116721f418e12dd1702d7bba165addd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.