commit 309dc309578fc770656718e0e733c8a92f229688
author Sneha Agarwal <snehagarwal@microsoft.com> Fri Mar 07 21:27:18 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Mar 07 21:27:18 2025
tree 4cd9b373ccee890a498c54ee8814ec8f0c5b518c
parent d293d4573317d133faa58f782c2c8222e4dd48fa

Cache Storage WPT: Update backend cache name type to std::u16string.

Currently, the cache name in Chromium does not correctly handle
DOMString (16-bit) values, particularly unpaired surrogates. These
characters should be preserved as-is instead of being replaced with a
<?> replacement character.

The issue originates after the cache name is sent through a Mojo message
and processed in the backend. Specifically, in
cache_storage_dispatcher_host.cc, the cache_name, which is received in
std::u16string format by the Open(), Has(), Match(), Keys(), and
Delete() APIs, is converted to UTF-8 format. This conversion leads to
the unintended replacement of unpaired surrogate characters.

This change ensures that the cache name is consistently handled as a
std::u16string throughout the system, preventing unintended character
replacements. However, it is important to note the following:

Mojo Message Conversion: While the cache name is stored and processed as
a std::u16string, it will still be converted to UTF-8 when sent over
Mojo. This behavior remains unchanged.

Read/Write Logic: When writing a cache entry, both UTF-8 and UTF-16
representations of the cache name are stored. When reading a cache
entry, we will first attempt to read the UTF-16 name. If it is
unavailable, we will fall back to reading the UTF-8 name for backward
compatibility with existing cache data.

By implementing this approach, we ensure proper handling of unpaired
surrogate sequences while maintaining backward compatibility with
previously stored cache names in UTF-8.

Bug: 41142654
Change-Id: I04787a410b6cab59b3b511534d7e9d1ec1c310cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6170241
Commit-Queue: Sneha Agarwal <snehagarwal@microsoft.com>
Reviewed-by: Mingyu Lei <leimy@chromium.org>
Reviewed-by: Steve Becker <stevebe@microsoft.com>
Reviewed-by: Rahul Singh <rahsin@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1429711}