commit | 30df3e54292125953ed6914aaea70ce050a04ba9 | [log] [tgz] |
---|---|---|
author | Shintaro Kawamura <kawasin@google.com> | Thu Apr 10 15:08:21 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Apr 10 15:08:21 2025 |
tree | 814cf6d23b348b098c40a364ca8b04118e2816fe | |
parent | 3123a09db41bf32e805da32c7169f23f357453b4 [diff] |
Reland "Introduce ProcessRankPolicyAndroid" This is a reland of commit 834b3f87c4e3fa04178aa2d59921e2bf60a72df6 Original change's description: > Introduce ProcessRankPolicyAndroid > > ProcessRankPolicyAndroid introduces the memory process priority concept > to Chrome on Android. This is to unblock introducing protected tab > concept to Chrome on Android which requires Performance Manager (e.g. > user edit information is only stored in PageNode out of Blink). > > ProcessRankPolicyAndroid replaces TabImportanceManager.java which has > updated content::ChildProcessImportance via > WebContentsAndroid::SetImportance() which calls > RenderWidgetHostImpl::SetImportance(). > > ProcessRankPolicyAndroid contains the whole logic of > TabImportanceManager.java and visibility related conditions for main > frame in ChildProcessLauncherHelperImpl.setPriority(). > > * From TabImportanceManager: > * Boosts the importance of the main frame of the focused tab to > ChildProcessImportance::IMPORTANT with ChangeUnfocusedPriority. > * Boosts the importance of the main frame of active tabs in invisible > windows to ChildProcessImportance::MODERATE. > * From ChildProcessLauncherHelperImpl.setPriority(): > * Boosts the importance of the main frame of non-focused but visible > tabs to ChildProcessImportance::IMPORTANT (if > ChangeUnfocusedPriority is disabled) or > ChildProcessImportance::MODERATE (if ChangeUnfocusedPriority is > enabled) > > ProcessRankPolicyAndroid does nothing to do with other frames in a page > other than the main frame. The priority of sub-frame processes are > updated by the existing logic in > ChildProcessLauncherHelperImpl.setPriority() which boosts sub-frames > with media stream and intersecting visible sub-frames. > > Memory priority for sub-frames from Performance Manager will be done > later. > > This also renames setImportance() method of WebContents.java > setPrimaryMainFrameImportance(). Historically the method had updated all > sub-frame importance, and https://crrev.com/c/1038759 changed it to > update the main frame only without renaming the java API. > > DesignDocument: go/clank-memory-priority-policy > > Bug: 401498479 > Change-Id: I9046295757ed04a706ff9b9fe34f8b4f846ec81d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6335184 > Reviewed-by: Bo Liu <boliu@chromium.org> > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Shin Kawamura <kawasin@google.com> > Cr-Commit-Position: refs/heads/main@{#1445059} Bug: 401498479 Change-Id: I0bf3516d3196119405d324ed7b48bfffc236b004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6437756 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Shin Kawamura <kawasin@google.com> Cr-Commit-Position: refs/heads/main@{#1445300}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.