[customize chrome] Fix the focus ring's color in the theme color picker

This CL fixes crbug.com/414764619 by removing the enclosing div
container of the custom color picker, i.e., by following the solution
mentioned in the bug.

The reported issue occurred because of the following:

- In the original code, the enclosing div element has its tabindex attribute set, and thus it is considered focused when the focus is moved.
- cr-theme-color's boundary color (box-shade) is determined by
--cr-focus-outline-color[1], while the div does not have this css
applied

The fix adopted here is to slot the custom picker icon into
ThemeColorElement, using cr-theme-color directly at the top-level with
all the attributes set to it. This causes the following behavior
changes:

- the cr-theme-color element becomes focusable
- when focused, the element is styled with the css that is consistent with the other grid elements.

The resulting border color is confirmed manually[2].

[1]:
https://source.chromium.org/chromium/chromium/src/+/main:ui/webui/resources/cr_components/theme_color_picker/theme_color.css;l=21;drc=d4c10b208905b9e6e715fa20e853700295375821
[2]:
https://screencast.googleplex.com/cast/NDY1Nzc5NzcwMTU2NjQ2NHwwYTUyOTI5ZC1mNg

Fixed: b:414764619
Change-Id: Ib645a3610a11edcc391fe8ded471a4326280ac8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7009000
Reviewed-by: Riley Tatum <rtatum@google.com>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Sho Mizoe <shomizoe@google.com>
Cr-Commit-Position: refs/heads/main@{#1527659}
5 files changed
tree: 7c9ba962e0677ccd9dc1b484c71154d7b2e55656
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .geminiignore
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. SECURITY_OWNERS
  82. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.