| commit | 105f25a2da9b8eba92d3f1af25c4174e5d793a01 | [log] [tgz] |
|---|---|---|
| author | Brian Sheedy <bsheedy@chromium.org> | Wed Feb 16 23:17:52 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 16 23:17:52 2022 |
| tree | 2c765af56e1c479579683d2731b7f73c58ea47bb | |
| parent | 3a13b80a52f890ef5a18cc2cdaf2f6a58d348ebd [diff] |
Reland "Add Gold dryrun usage to Blink web tests" This is a reland of a6898145c204c1d2b8cf7436c04ff4ced3c1a468 Changes from original: * Included Gold files in the webdriver tests. * Removed use of Gold-specific service account. Standard Chromium service accounts have instead been granted permissions to upload to the Gold server. Original change's description: > Add Gold dryrun usage to Blink web tests > > Adds a dryrun usage of Skia Gold to the pixel tests in the Blink web > tests. Data will be uploaded to Gold as if it were being used for > image comparisons, but any output or exceptions will be ignored. This > is so that the Gold team can see what sort of data the web tests are > producing in order to help determine whether Gold can be adapted to > meet the tests' needs. > > Test runtime with this patch vs. without seems to be within margin > of error (+/- a few minutes per bot), so this is not expected to have > any noticeable impact on testing. > > Bug: 1290526 > Change-Id: Iee484e59c45fd1eef2c4cd1b1c563358eafe653b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312012 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Auto-Submit: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/main@{#969203} Bug: 1290526 Change-Id: Ibfb4d9bdaa96cf86defa34c04da64daf9015a637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3452825 Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#972130}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.