commit 3163cf46b5a41450fed413404f1d137ead3e3870
author Rakina Zata Amni <rakina@chromium.org> Wed Dec 08 08:27:58 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Dec 08 08:27:58 2021
tree f48260d7a4a8cec9bbe87704df5c5b9cae85050e
parent b930d189075bf3046c58d98047bdfff83a5a0709

Always replace initial empty document's session history entry

Currently the replacement of the initial empty document's session
history entry is not consistent between main frames and subframes: we
always replace on subframes, but only replace on one case (the
navigation after window.open()) on main frames. This CL aligns the
behavior between main frames and subframes, by making us always replace
on main frames as well.

This CL introduces a few changes of behavior:
- Session history entries for the initial empty document will always
  get replaced on the next navigation, on main frames and subframes.
  This includes same-document navigations.
- The synchronous about:blank commit for window.open() is no longer
  ignored. Since this is the last case of a navigation getting ignored,
  this means we don't ignore any committed navigations anymore. This
  also means the browser-side listeners (e.g. WebContentsObserver's
  navigation related functions) will now be notified of this navigation.

This CL corresponds to Step 3 of the implementation plan in this doc:
https://docs.google.com/document/d/1H81oAG13f21fUf-IGHH8AnjNVJFtaThowl5Ki9hWw5E/edit#heading=h.edywj4xq7t9g

Bug: 1215096, 501960, 1197308
Change-Id: I1807a2a86d0370d0da3791bf5f76ba63d3a26879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3237493
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Charles Reis <creis@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/main@{#949428}