commit | 318c0bce71b6decea3765ffd42ae161dc9af7d11 | [log] [tgz] |
---|---|---|
author | Donn Denman <donnd@chromium.org> | Wed Oct 06 00:07:15 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Oct 06 00:07:15 2021 |
tree | de51818ea2632a3225dbe720216843afc977a94e | |
parent | b249f941ce96c975634f2d2930bcd9f8a373b5f8 [diff] |
[RSearches] Fix the touch location in the SERP Fixes the vertical offset issue for touches within the content of the SERP that happens for Related Searches when in-bar results are being shown. There are two possible positions for the carousel: in bar and in Panel. When we show one in the panel we need to offset the touch locations to hit the right part of the serp, but we're doing that when the in-bar carousel shows even though it should only offset for the in-panel carousel. This CL adds a boolean so we can get the height of either the in-bar or in-panel carousel, which allows us to compute the correct Y offset of the content area that displays the SERP. BUG=1250546 Change-Id: Ice6b9932208210a433224aa9216978e474d29d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198303 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by: Matt Jones <mdjones@chromium.org> Reviewed-by: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/main@{#928429}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.