Google Git
Sign in
chromium / chromium / src / 31c43a08c5d178622c7e7487d0e94e45084d4f45
commit31c43a08c5d178622c7e7487d0e94e45084d4f45[log] [tgz]
authorMichael Thiessen <mthiesse@chromium.org>Wed Aug 12 21:47:22 2020
committerCommit Bot <commit-bot@chromium.org>Wed Aug 12 21:47:22 2020
treed4c9ac5a36e6bd980b172156a8d1145481533b64
parent99f3430032353f645ae3f1aba0ded3be1749454f [diff]
Fix state leaked by ExternalNavigationHandler unit tests

We were leaking the overridden ApplicationContext, leading to other
tests failing when interacting with mocks created by the
ExternalNavigationHandler.

Not sure why this isn't occurring on bots, but it does locally.

Change-Id: Ie283a6f96f69dec2a8e70c4ed11e025f6e475c68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353121
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797433}
1 file changed
tree: d4c9ac5a36e6bd980b172156a8d1145481533b64
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.