commit | c39a9afef01acc363652cb18eb5cdcf5952c4064 | [log] [tgz] |
---|---|---|
author | Matthew Jones <mdjones@chromium.org> | Mon Jul 16 23:16:27 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jul 16 23:16:27 2018 |
tree | 5c3ad4d8d594bdc9364b820abe305387bc86fcc4 | |
parent | 36479a9906fbdc778344def1e3b1743f585c090c [diff] |
Add ability to show overflow menu icon row at bottom of menu This patch revives some overflow menu code from ye-olde days of Chrome Home with a sprinkle of new-age technology (see https://codereview.chromium.org/2821223004 for the original patch). More specifically, AppMenuIconRowFooter, icon_row_menu_footer, and app_menu_button_tint have been revived almost exactly as they were. Now, when Duet is enabled the icon row is placed at the bottom of the overflow menu to make it easier to reach with one hand. The major difference between this and Chrome Home's version is how the bottom icon row is initialized. This patch adds AppMenuPropertiesDelegate#onFooterViewInflated() which gives delegates the opportunity to make changes to the view immediately post-inflation. This patch breaks the data-saver menu promo while Duet is enabled, this will be fixed in a follow-up patch which places it at the top of the menu. Bug: 847632 Change-Id: Iac44bdc2880c118b97102ef074134a6f13b50da0 Reviewed-on: https://chromium-review.googlesource.com/1135892 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#575472}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .