Remove base::Value::Equals().
Bug: 646113
Change-Id: I094b1e7367cc95ee9be6e4b6147b40ab8fa95a9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3759533
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1024563}
diff --git a/base/json/json_reader_fuzzer.cc b/base/json/json_reader_fuzzer.cc
index 3cde253..3eb7b44 100644
--- a/base/json/json_reader_fuzzer.cc
+++ b/base/json/json_reader_fuzzer.cc
@@ -35,7 +35,7 @@
absl::optional<Value> deserialized =
JSONReader::Read(StringPiece(serialized));
CHECK(deserialized);
- CHECK(value.Equals(&deserialized.value()));
+ CHECK_EQ(value, deserialized.value());
}
return 0;
diff --git a/base/values.cc b/base/values.cc
index 2fdddce..178ca34 100644
--- a/base/values.cc
+++ b/base/values.cc
@@ -1474,11 +1474,6 @@
return lhs.is_list() && lhs.GetList() == rhs;
}
-bool Value::Equals(const Value* other) const {
- DCHECK(other);
- return *this == *other;
-}
-
size_t Value::EstimateMemoryUsage() const {
switch (type()) {
#if BUILDFLAG(ENABLE_BASE_TRACING)
diff --git a/base/values.h b/base/values.h
index f5ce820..73b91b4 100644
--- a/base/values.h
+++ b/base/values.h
@@ -1144,13 +1144,6 @@
return !(lhs == rhs);
}
- // Compares if two Value objects have equal contents.
- // DEPRECATED, use `operator==(const Value& lhs, const Value& rhs)` instead.
- // TODO(crbug.com/646113): Delete this and migrate callsites.
- //
- // DEPRECATED: prefer direct use of the equality operator instead.
- bool Equals(const Value* other) const;
-
// Estimates dynamic memory usage. Requires tracing support
// (enable_base_tracing gn flag), otherwise always returns 0. See
// base/trace_event/memory_usage_estimator.h for more info.
