Support redundant response start in PageTimingMetricsSender.

PageTimingMetricsSender::DidStartResponse() can be invoked multiple
times with the same resource id, despite the long-standing DCHECK
suggesting that it doesn't happen (see bug for repro). Prior to
crrev.com/c/4321469, when that happened, the `PageResourceDataUse`
instance already in `page_resource_data_use_` was reused (emplace()
no-ops if the element already exist). Since crrev.com/c/4321469,
the existing `PageResourceDataUse` was deleted and replaced with
a new one. This could result in a dangling pointer in
`modified_resources_`. This CL solves the issue by making
`InsertPageResourceDataUse()` no-op if there is already an entry
with the given id in `page_resource_data_use_`.

Bug: 1504430
Change-Id: Ibd2108006e6ea284f12a722cf16ff72da58e6cea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5056238
Auto-Submit: Francois Pierre Doray <fdoray@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Hao Liu <haoliuk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1233966}
2 files changed
tree: 784ae264ebec013f546ab7630e1aa2e7548cef89
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.