Google Git
Sign in
chromium / chromium / src / 32b7b02211dcde6eedfbb314ccb60f918b0a1598
commit32b7b02211dcde6eedfbb314ccb60f918b0a1598[log] [tgz]
authorRushan Suleymanov <rushans@google.com>Tue Nov 05 01:31:45 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 05 01:31:45 2024
treeee796ccc7e87f750b477ed863d374c32066609e5
parenta8fff9ee1b09def37c002139030387a2d38ae297 [diff]
[Tab Group Sync] Update local tab group when connecting to new saved group

This CL makes the behavior of UpdateLocalTabGroup() method on desktop
similar to the iOS implementation, allowing simultaneously connecting a
local tab group to a new saved tab group, and then updating its content.

This CL does not have behavioral changes. It's a pre-requisite for a
seamless transition saved -> shared tab group on remote devices which
have open saved tab group which was shared on another device. The new
shared tab group should be connected to the existing local tab group,
and it may contain a different set of tabs.

To keep the existing behavior, a new method ConnectLocalTabGroup() was
added. It's called now instead of UpdateLocalTabGroup() but does the
same logic when the group wasn't connected.

Bug: 370745855, 375922649
Change-Id: I0a297e23b09724ea8e6e67d426c1df97da6969e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5970214
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1378050}
3 files changed
tree: ee796ccc7e87f750b477ed863d374c32066609e5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.