commit | 32d30f5377ca1c97055db0db2c9a6970a0d7af2c | [log] [tgz] |
---|---|---|
author | Tao Wu <wutao@chromium.org> | Thu Apr 11 22:17:56 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Apr 11 22:17:56 2024 |
tree | 129f35682159c1af0b80a38da2c80b80b98a9afc | |
parent | d98895508d007cafb7ff15f134ce23deec0d4a6c [diff] |
growth: Fix AnchorViewWidgetObserver UAF There are multiple code paths to remove the AnchorViewWidgetObserver. The problematic code is that when the OnWidgetVisibilityChanged(), we have already removed the observer, but we did not mark it. So later in ~AnchorViewWidgetObserver(), we try to access the `active_widget_`, which may not exist any more. Bug: 333611806 Test: the test is in another cl 5438900. Change-Id: Ic2e7c582fc65b9391b0389359bd521b41615a889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5446881 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1286135}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.