Google Git
Sign in
chromium / chromium / src / 32e63698fdf3f7cb3dc6600802e829c390e486fd
commit32e63698fdf3f7cb3dc6600802e829c390e486fd[log] [tgz]
authorCurtis McMullan <curtismcmullan@chromium.org>Thu Mar 31 04:53:14 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Mar 31 04:53:14 2022
tree8e820c27271d057cd2b02ef19aaf3c45af446fc8
parentbea1e6459392c788522e31ed35526b5061c7ba8c [diff]
lacros: merge composition and surrounding text

Currently the results emitted from exo::TextInput::GetTextRange
and exo::TextInput::GetTextFromRange are incorrect. They report
extra characters when they shouldn't.

This is due to a mismatch between the model of surrounding/composition
text used within exo::TextInput, and the implicit model used within
the surrounding text updates sent from lacros via wayland.

exo::TextInput models surrounding and composition text as two
separate pieces of text that need to be combined together. Whereas
the surrounding text sent from lacros ALWAYS contains the current
composition text (composition is a subset of surrounding).

This caused the text emitted from exo::TextInput::GetTextFromRange
to include duplicate copies of the current composition text.

This CL fixes this issue by modelling composition text as a subset
of surrounding text in exo::TextInput, which matches the model used
by the surrounding text sent from lacros via wayland.

BUG=b:225065084

Change-Id: I8cf1cc7bc206f60dd4693d5ab624d15840e73c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3528950
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#987338}
3 files changed
tree: 8e820c27271d057cd2b02ef19aaf3c45af446fc8
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.