Google Git
Sign in
chromium / chromium / src / 32f10a2b832b58689e2456c0da9eb335ba85436c
commit32f10a2b832b58689e2456c0da9eb335ba85436c[log] [tgz]
authorErik Chen <erikchen@chromium.org>Tue May 16 01:02:40 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 16 01:02:40 2023
tree29a30fa2f533e70421f1ba023959157ad474fcc9
parente2ff2a4a2d7db49de89b13e9858d750fc3fb341e [diff]
cr-elements: Uniform padding for buttons in cr-dialog.

In situations where the the button-container border is visible,
non-uniform padding for cr-buttons results in off-center buttons. This
CL modifies the default padding to be a uniform 16px.

This CL fixes the layout for credit_card_edit_dialog.html as it was
overriding the button padding with non-uniform padding, which resulted
in the problem noted above. I manually verified that this also fixes a
similar issue for chrome://settings/addresses.

This CL will induce a small (8px) vertical layout shift cr-buttons in
button-containers for other WebUI surfaces.

Fixed: 1403663
Change-Id: I6dac729c0f3c9a3ffaff7af77851f2ed49139a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4482616
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144502}
2 files changed
tree: 29a30fa2f533e70421f1ba023959157ad474fcc9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.