commit 3316eece65ef22154aadb4112bcda060e4e8f15f
author Moe Ahmadi <mahmadi@chromium.org> Sat Jun 03 00:31:43 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Jun 03 00:31:43 2023
tree 32ace109dde2e8a13ac461859fef8257cab80e81
parent 0202f99cda463e5c7e97b478a0ce37dccae450a1

[omnibox][webui] Fixes Action selection + simplifications

Actions can be selected in the WebUI Omnibox Popup via tab navigation
in the omnibox input, albeit the focus indicator is not updated
accordingly. However, Actions cannot be selected via mouse click.

In the former case, OmniboxEditModel keeps track of the popup selection.
In the latter case the popup selection is synthesized in RealboxHandler
and communicated to OmniboxEditModel. However RealboxHandler always
creates its own instance of the ACController which is different from the
instance owned by the OmniboxEditModel which powers the Omnibox.

This CL makes the RealboxHandler use the same OmniboxController - and
thus the same OmniboxEditModel and ACController instances - as the
omnibox when being used in the context of the WebUI omnibox popup.

Additionally, this CL makes a bunch of code simplifications such as
unifying the mojom Page interface between the realbox and omnibox popup,
eliminating the use of AutocompleteControllerEmitter in favor of direct
observation of ACController, and removing unused variables.

Bug: 1442068
Change-Id: Ia181873bc0bbd370f1356f1689c7c231a3ffbe9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585009
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1152857}