Google Git
Sign in
chromium / chromium / src / 3325d15446fe396b715fbedfe062e21827ea55e1
commit3325d15446fe396b715fbedfe062e21827ea55e1[log] [tgz]
authorSylvain Defresne <sdefresne@chromium.org>Mon Apr 29 15:16:52 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Apr 29 15:16:52 2024
treeb141bacbb2afcb58174ad12e385aa47cb25b68ac
parent97f0c423a84fb26b95f070c541ecfc25ce13c0ff [diff]
[ios] Fix scroll position when using optimised session restoration

When using WKWebView's native session data, the scroll position is
saved. This causes the view to be incorrectly positioned when user
scroll the view, quit the app and reload it, if the native session
data is used and kSmoothScrollingDefault is enabled.

This was only visible with optimised session restoration since the
legacy session restoration had a regression causing it to fail to
load the native session data (thus hiding the regression from the
fullscreen code).

This CL change SessionRestorationServiceImpl to not load the native
session data if kSmoothScrollingDefault is enabled, behaving in the
same way as LegacySessionRestorationService (bug included).

    Fixing LegacySessionRestorationService to correctly load the
    native session would make this bug happen for all users. This
    is undesirable.

Bug: 337816888
Fixed: 336613927
Change-Id: Ifb3f448cf30dd6f2c8044dd4cfd707a2ffec590c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490735
Reviewed-by: Aliona Dangla <alionadangla@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293694}
2 files changed
tree: b141bacbb2afcb58174ad12e385aa47cb25b68ac
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.