[omnibox] Fixes reporting zero-suggest metrics in searchboxstats.

crrev.com/c/5280536 had a subtle bug where the internal ACResult's
session data was being swapped with the published ACResult in Sync and
LastAsync autocomplete passes. This resulted in that data to be lost
from the internal ACResult and not be set on the ACMatches in
ACController::UpdateSearchboxStats(). The unit tests also failed to
detect that. This CL fixes that bug, renames ACResult::Swap() to
ACResult::SwapMatchesWith(), reorganizes the code and adjusts the
comments for clarity, and improves the unit tests.

crrev.com/c/5286774 also had a subtle bug where zero_prefix_enabled
was being set to true in ACController::UpdateSearchboxStats() which
is reached when zero-prefix suggestions are shown, not zero-prefix
suggestions could've been shown as it is expected by this metric to
report. This CL also fixes that by setting zero_prefix_enabled earlier
in ACController::Start().

This CL also enables the feature by default to facilitate merging this
change (1 CL to merge instead of 2) to m123.

Bug: 1307142
Change-Id: I0d53f429ff8b39aa5b4257bbf4219e729d6822ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5309407
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1263124}
8 files changed
tree: e980b128c27703364378316f712a4c9b649ac14b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.