[omnibox] Fixes reporting zero-suggest metrics in searchboxstats. crrev.com/c/5280536 had a subtle bug where the internal ACResult's session data was being swapped with the published ACResult in Sync and LastAsync autocomplete passes. This resulted in that data to be lost from the internal ACResult and not be set on the ACMatches in ACController::UpdateSearchboxStats(). The unit tests also failed to detect that. This CL fixes that bug, renames ACResult::Swap() to ACResult::SwapMatchesWith(), reorganizes the code and adjusts the comments for clarity, and improves the unit tests. crrev.com/c/5286774 also had a subtle bug where zero_prefix_enabled was being set to true in ACController::UpdateSearchboxStats() which is reached when zero-prefix suggestions are shown, not zero-prefix suggestions could've been shown as it is expected by this metric to report. This CL also fixes that by setting zero_prefix_enabled earlier in ACController::Start(). This CL also enables the feature by default to facilitate merging this change (1 CL to merge instead of 2) to m123. Bug: 1307142 Change-Id: I0d53f429ff8b39aa5b4257bbf4219e729d6822ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5309407 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1263124}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.