DeskButton: Fix label discolorations This CL fixes some issues with contrast between the label and the desk button background. Previously, the label assumed that we had an opaque background and so it tried to contrast the text color with this imaginary background color. We fix this by setting auto color readability to false for the label. We were also experiencing issues where sometimes the color for the label text would not update correctly on theme change. We fixed this by assigning a color ID for the label rather than a color. Bug: b/287129850 Change-Id: I77a7779812d9a432cb7cc75cc51f8f93628ae24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4679620 Reviewed-by: Yongshun Liu <yongshun@chromium.org> Reviewed-by: Daniel Andersson <dandersson@chromium.org> Commit-Queue: Ben Becker <benbecker@chromium.org> Cr-Commit-Position: refs/heads/main@{#1168996}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.