Fix DCHECK error in HTMLCanvasElement::Paint() for OffscreenCanvas frames. PaintPreviewState was added in Document and was factored into the "printing" state in WebLocalFrameImpl::CapturePaintPreview, which does not necessarily update the Document's printing_ state, but rather, the paint_preview_ state. HTMLCanvasElement::Paint() only accounts for the Document's printing_ state and not paint_preview_ state, causing the DCHECK to trigger when OffscreenCanvases are loaded. This CL should fix this by checking if either the printing_ state or the paint_preview_ state is set to kPrinting or kPaintingPreview/kPaintingPreviewSkipAcceleratedContent, respectively. This only happens on chrome-branded builds (i.e., is_chrome_branded=true) Bug: 413405915 Change-Id: I8d4b50e8b954f4b4d640eab94ceab38bee6a3fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6489433 Commit-Queue: John Kim <johnykim@google.com> Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1451928}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.