Fix DCHECK error in HTMLCanvasElement::Paint() for OffscreenCanvas frames.

PaintPreviewState was added in Document and was factored into the
"printing" state in WebLocalFrameImpl::CapturePaintPreview, which does
not necessarily update the Document's printing_ state, but rather, the
paint_preview_ state. HTMLCanvasElement::Paint() only accounts for the
Document's printing_ state and not paint_preview_ state, causing the
DCHECK to trigger when OffscreenCanvases are loaded. This CL should fix
this by checking if either the printing_ state or the paint_preview_
state is set to kPrinting or
kPaintingPreview/kPaintingPreviewSkipAcceleratedContent, respectively.
This only happens on chrome-branded builds (i.e.,
is_chrome_branded=true)

Bug: 413405915
Change-Id: I8d4b50e8b954f4b4d640eab94ceab38bee6a3fcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6489433
Commit-Queue: John Kim <johnykim@google.com>
Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1451928}
1 file changed
tree: 4b228f9c1d2d74c4360d559d98e02110406d87e2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.