Google Git
Sign in
chromium / chromium / src / 340e7ada8f134cde3f11f67a6823aa567f086de5
commit340e7ada8f134cde3f11f67a6823aa567f086de5[log] [tgz]
authorDuong Dac <ddac@google.com>Wed Mar 26 15:53:30 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Mar 26 15:53:30 2025
tree82afbab793b31d7b96ef5c3dffe957993dd600b6
parenteb95566bc200e5657e6b7e2c7b478dcb285f76e1 [diff]
Reland "[B4B] Migrate bookmark menu on Mac to be a merged surface"

This reverts commit e717fef112c4d3a606c90e43f234718be79842ca.

Reason for revert: test fixed. BookmarkMenuBridge was observing
BookmarkMergedSurfaceService, but the test was waiting for
BookmarkModel loaded.

Original change's description:
> Revert "[B4B] Migrate bookmark menu on Mac to be a merged surface"
>
> This reverts commit 0733ed3412ef25373862475f5e8c7b4441e14103.
>
> Reason for revert: Observing failures for BookmarksMenuIsRestoredAfterProfileSwitch
> test in sheriff-o-matic
>
> Original change's description:
> > [B4B] Migrate bookmark menu on Mac to be a merged surface
> >
> > This change adds Account bookmarks to the bookmark menu, mirroring the
> > order found in the bookmark bar and sidebar.
> >
> > Upcoming change:
> > - Update BookmarkRestorer to observe BookmarkMergedSurfaceService instead of BookmarkModel.
> >
> > Bug: 390398329
> > Change-Id: I3dff9c158ab7e2141d6d6c94e1cd9ac022a73e0a
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6367038
> > Reviewed-by: David Roger <droger@chromium.org>
> > Reviewed-by: Ryan Sultanem <rsult@google.com>
> > Commit-Queue: Duong Dac <ddac@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1437646}
>
> Bug: 390398329
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I38e927033fd4950ae66c9827c9301acfe20dc1d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6393999
> Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org>
> Owners-Override: Kelvin Jiang <kelvinjiang@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1437743}

Bug: 390398329
Change-Id: I659af3782f1b22255eb60f990cc2aaa7eb9aacc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6396876
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Duong Dac <ddac@chromium.org>
Reviewed-by: Ryan Sultanem <rsult@google.com>
Cr-Commit-Position: refs/heads/main@{#1438163}
6 files changed
tree: 82afbab793b31d7b96ef5c3dffe957993dd600b6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.