Google Git
Sign in
chromium / chromium / src / 343b5fee853cc1e9496f42c2a8b7422bdc6a7fa7
commit343b5fee853cc1e9496f42c2a8b7422bdc6a7fa7[log] [tgz]
authorJoe DeBlasio <jdeblasio@chromium.org>Sat Feb 25 01:44:26 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Feb 25 01:44:26 2023
tree63b57fcc8b9ae1c96b05e31237aa25c106489b0c
parent64411473cf6805d366ac66c81d5cf27eda384194 [diff]
Record metrics for not-upgraded-but-eligible navigations

This CL updates the HFM and HTTPS Upgrading logic to record a new
kUpgradeNotAttempted bucket when navigations would have been upgraded,
but upgrading wasn't enabled.

Prior to this change, both HFMv1 and v2 codepaths checked whether
upgrading was enabled early on and early-aborted if not enabled. The
biggest change in this CL is to move checking whether upgrading is
enabled to the very last moment possible so that we can record metrics
at that moment.

Bug: 1418100
Change-Id: I1ad7566adfda636a9db3f5b6c15d918bd9df1110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4285421
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Chris Thompson <cthomp@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1109922}
10 files changed
tree: 63b57fcc8b9ae1c96b05e31237aa25c106489b0c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.