Google Git
Sign in
chromium / chromium / src / 34757d8e7415e4f4b8be9a01b0e9786e75092f1b
commit34757d8e7415e4f4b8be9a01b0e9786e75092f1b[log] [tgz]
authorRohit Agarwal <roagarwal@chromium.org>Fri May 27 17:24:39 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 27 17:24:39 2022
tree8aa9765b1c594f9543e9b7d6f0345eacc964db6b
parent79b5b25dad5e27e328b76391dbc488a7b3ece879 [diff]
[Android] [IncognitoReauth] Add check on activity type before accessing
start surface supplier.

M103 merge, approved at crbug.com/1325331#c14

Currently, we are referencing the mStartSurfaceSupplier.get() to get
the TabSwitcherCustomViewManager without checking the underlying
activity type. The mStartSurfaceSupplier.get() can return null for
activity type other than Tabbed type.

This CL adds a check on activity type before referencing methods
from start surface.

(cherry picked from commit 3e22a2ed906e196503f37ab42c0818324d5d7c2c)

Bug: 1325331, 1227656
Change-Id: Iab33426c2bf69fd797a3a71bad5da69ed2cf4c11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3647868
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1004818}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3669899
Auto-Submit: Rohit Agarwal <roagarwal@chromium.org>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#308}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
2 files changed
tree: 8aa9765b1c594f9543e9b7d6f0345eacc964db6b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.